[
https://issues.apache.org/jira/browse/HADOOP-18530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639968#comment-17639968
]
ASF GitHub Bot commented on HADOOP-18530:
-----------------------------------------
mehakmeet commented on code in PR #5168:
URL: https://github.com/apache/hadoop/pull/5168#discussion_r1033426018
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/VectoredReadUtils.java:
##########
@@ -310,6 +310,7 @@ public static ByteBuffer sliceTo(ByteBuffer readData, long
readOffset,
readData = readData.slice();
Review Comment:
Add a comment here explaining this sequence.
> ChecksumFileSystem::readVectored might return byte buffers not positioned at 0
> ------------------------------------------------------------------------------
>
> Key: HADOOP-18530
> URL: https://issues.apache.org/jira/browse/HADOOP-18530
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 3.3.5
> Reporter: Harshit Gupta
> Priority: Blocker
> Labels: pull-request-available
>
> Checksystem::readVectored method returns the byte buffers that are not
> positioned at 0, which might be the underlying assumption for the readers
> like ORC.
>
> cc:/ [~mthakur] [~rbalamohan] [[email protected]]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
