goiri commented on code in PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#discussion_r1035298448
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java:
##########
@@ -1759,6 +1764,72 @@ public void testRefreshCallQueue() throws Exception {
assertTrue(err.toString().contains("No arguments allowed"));
}
+ @Test
+ public void testDumpState() throws Exception {
+ MockStateStoreDriver driver = new MockStateStoreDriver();
+ driver.clearAll();
+ // Add two records for block1
+ driver.put(MembershipState.newInstance("routerId", "ns1",
+ "ns1-ha1", "cluster1", "block1", "rpc1",
+ "service1", "lifeline1", "https", "nn01",
+ FederationNamenodeServiceState.ACTIVE, false), false, false);
+ driver.put(MembershipState.newInstance("routerId", "ns1",
+ "ns1-ha2", "cluster1", "block1", "rpc2",
+ "service2", "lifeline2", "https", "nn02",
+ FederationNamenodeServiceState.STANDBY, false), false, false);
+ Configuration conf = new Configuration();
+ conf.setClass(RBFConfigKeys.FEDERATION_STORE_DRIVER_CLASS,
+ MockStateStoreDriver.class,
+ StateStoreDriver.class);
+ ByteArrayOutputStream buffer = new ByteArrayOutputStream();
+ try (PrintStream stream = new PrintStream(buffer)) {
+ RouterAdmin.dumpStateStore(conf, stream);
+ }
+ final String expected =
+ "---- DisabledNameservice ----\n" +
+ "\n" +
+ "---- MembershipState ----\n" +
+ " ns1-ha1-ns1-routerId:\n" +
+ " dateCreated: XXX\n" +
+ " dateModified: XXX\n" +
+ " routerId: \"routerId\"\n" +
+ " nameserviceId: \"ns1\"\n" +
+ " namenodeId: \"ns1-ha1\"\n" +
+ " clusterId: \"cluster1\"\n" +
+ " blockPoolId: \"block1\"\n" +
+ " webAddress: \"nn01\"\n" +
+ " rpcAddress: \"rpc1\"\n" +
+ " serviceAddress: \"service1\"\n" +
+ " lifelineAddress: \"lifeline1\"\n" +
+ " state: \"ACTIVE\"\n" +
+ " isSafeMode: false\n" +
+ " webScheme: \"https\"\n" +
+ " \n" +
+ " ns1-ha2-ns1-routerId:\n" +
+ " dateCreated: XXX\n" +
+ " dateModified: XXX\n" +
+ " routerId: \"routerId\"\n" +
+ " nameserviceId: \"ns1\"\n" +
+ " namenodeId: \"ns1-ha2\"\n" +
+ " clusterId: \"cluster1\"\n" +
+ " blockPoolId: \"block1\"\n" +
+ " webAddress: \"nn02\"\n" +
+ " rpcAddress: \"rpc2\"\n" +
+ " serviceAddress: \"service2\"\n" +
+ " lifelineAddress: \"lifeline2\"\n" +
+ " state: \"STANDBY\"\n" +
+ " isSafeMode: false\n" +
+ " webScheme: \"https\"\n" +
+ " \n" +
+ "\n" +
+ "---- MountTable ----\n" +
+ "\n" +
+ "---- RouterState ----";
+ // Replace the time values with XXX
+ assertEquals(expected,
+ buffer.toString().trim().replaceAll("[0-9]{4,}+", "XXX"));
Review Comment:
Might be cleaner to use a regex matches?
We have hamcrest right? Then we can do:
```
assertThat("FooBarBaz", matchesPattern("^Foo"));
```
https://piotrga.wordpress.com/2009/03/27/hamcrest-regex-matcher/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
