steveloughran commented on code in PR #4039:
URL: https://github.com/apache/hadoop/pull/4039#discussion_r1035926910
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:
##########
@@ -314,18 +314,21 @@ public void sendRequest(byte[] buffer, int offset, int
length) throws IOExceptio
if (this.isTraceEnabled) {
startTime = System.nanoTime();
}
- try (OutputStream outputStream = this.connection.getOutputStream()) {
- // update bytes sent before they are sent so we may observe
- // attempted sends as well as successful sends via the
- // accompanying statusCode
- this.bytesSent = length;
+ OutputStream outputStream;
+ try {
+ try {
+ outputStream = this.connection.getOutputStream();
+ } catch (IOException e) {
+ // If getOutputStream fails with an exception due to 100-continue
Review Comment:
i still dont like this.
there are a lot of reasons for failure, given this is the call which tries
to set up the entire http request. if it is only expect 100 errors then
1. handler needs to identify those and throw everything else
2. you need a strategy for downgrading
as it is, it looks to me that if you have any problem talking to the far end
then the method will silently swallow it, while updating the bytes sent counter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
