dingshun3016 commented on PR #5170: URL: https://github.com/apache/hadoop/pull/5170#issuecomment-1336857490
> > > Now that, this case only happen when invoke addBlockPool() and CachingGetSpaceUsed#used < 0, I have an idea, is it possible to add a switch, not add lock when ReplicaCachingGetSpaceUsed#init() at first time , and add it at other times > > > > > > This makes sense to me, get replicas usage message no need strong consistency.@Hexiaoqiao any suggestion? > > Thanks for the detailed discussions. +1. it seems good to me. BTW, I try to dig PR to fix this bug but no found. It just at out internal branch which not refresh space used at init stage. And refresh-used is one complete async thread (at CachingGetSpaceUsed) , thus it could not dead lock when DataNode instance restart. Thanks. Thanks replay. looks like this PR [HDFS-14986](https://issues.apache.org/jira/browse/HDFS-14986), forbid refresh() when ReplicaCachingGetSpaceUsed#init() at first time. I prefer to not add lock when ReplicaCachingGetSpaceUsed#init() at first time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
