Neilxzn commented on code in PR #5184:
URL: https://github.com/apache/hadoop/pull/5184#discussion_r1040597476
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -702,8 +702,9 @@ public boolean truncate(String src, long newLength, String
clientName)
RemoteMethod method = new RemoteMethod("truncate",
new Class<?>[] {String.class, long.class, String.class},
new RemoteParam(), newLength, clientName);
+ // Truncate can return true/false, so don't expect a result
Review Comment:
SetReplication API has the same issue. I think `setReplication` API should
call `rpcClient.invokeAll(locations, method)` like `delete` API. I have fix
it in next commit. Please review it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
