[
https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643779#comment-17643779
]
ASF GitHub Bot commented on HADOOP-18546:
-----------------------------------------
steveloughran commented on code in PR #5176:
URL: https://github.com/apache/hadoop/pull/5176#discussion_r1040769983
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java:
##########
@@ -524,30 +527,33 @@ public void testStreamPurgeDuringReadAheadCallExecuting()
throws Exception {
final ReadBufferManager readBufferManager
= ReadBufferManager.getBufferManager();
+ final int readBufferTotal = readBufferManager.getNumBuffers();
+
//Sleeping to give ReadBufferWorker to pick the readBuffers for processing.
- Thread.sleep(1_000L);
+ Thread.sleep(readBufferTransferToInProgressProbableTime);
Assertions.assertThat(readBufferManager.getInProgressCopiedList())
- .describedAs("InProgressList should have 3 elements")
- .hasSize(3);
+ .describedAs("InProgressList should have " + readBufferQueuedCount + "
elements")
+ .hasSize(readBufferQueuedCount);
+ final int freeListBufferCount = readBufferTotal - readBufferQueuedCount;
Assertions.assertThat(readBufferManager.getFreeListCopy())
- .describedAs("FreeList should have 13 elements")
- .hasSize(13);
+ .describedAs("FreeList should have " + freeListBufferCount +
"elements")
Review Comment:
you can actually use string.format patterns here; most relevant for on
demand toString calls which are more expensive. I'm not worrying about it here
though
> disable purging list of in progress reads in abfs stream closed
> ---------------------------------------------------------------
>
> Key: HADOOP-18546
> URL: https://issues.apache.org/jira/browse/HADOOP-18546
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.4
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> turn off the prune of in progress reads in
> ReadBufferManager::purgeBuffersForStream
> this will ensure active prefetches for a closed stream complete. they wiill
> then get to the completed list and hang around until evicted by timeout, but
> at least prefetching will be safe.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
