cnauroth commented on code in PR #5190:
URL: https://github.com/apache/hadoop/pull/5190#discussion_r1041276776
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java:
##########
@@ -2959,6 +2960,20 @@ protected ResourceTrackerService
createResourceTrackerService() {
mockRM.stop();
}
+ private void pollingAssert(Supplier<Boolean> supplier, String message)
Review Comment:
In hadoop-common, there is a similar helper method:
`org.apache.hadoop.test.GenericTestUtils#waitFor`. This also has some other
nice features, like providing a thread dump for troubleshooting if it times
out. Can you please look at reusing that method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
