lnbest0707 commented on PR #5196: URL: https://github.com/apache/hadoop/pull/5196#issuecomment-1343068816
@slfan1989 thanks a lot for your review. Will add the instructions, do you have any suggestions where to add it? Just in the commit message or in a separate file (or which file). Besides, I feel the [issue](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5196/2/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html) reported by Jenkins a false alert. The "Unsynchronized access" reported by it is a READ call from a log function. I don't think we should add any locks on logging call. Please share any suggestions to bypass it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
