[ 
https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645299#comment-17645299
 ] 

ASF GitHub Bot commented on HADOOP-18546:
-----------------------------------------

steveloughran commented on PR #5198:
URL: https://github.com/apache/hadoop/pull/5198#issuecomment-1344327283

   not happy about javadoc failures, but looks unrelated (annotation issues? 
javadoc changes?).
   
   going to approve this myself because it's only a test change, and the change 
is just removing some flaky asserts plus the fix from @pranavsaxena-microsoft . 
If I'd checked out the PR and tested locally before the merge i would have just 
included them in the original commit.
   
   +1




> disable purging list of in progress reads in abfs stream closed
> ---------------------------------------------------------------
>
>                 Key: HADOOP-18546
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18546
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.3.4
>            Reporter: Steve Loughran
>            Assignee: Pranav Saxena
>            Priority: Major
>              Labels: pull-request-available
>
> turn off the prune of in progress reads in 
> ReadBufferManager::purgeBuffersForStream
> this will ensure active prefetches for a closed stream complete. they wiill 
> then get to the completed list and hang around until evicted by timeout, but 
> at least prefetching will be safe.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to