JackBuggins commented on code in PR #4537:
URL: https://github.com/apache/hadoop/pull/4537#discussion_r1044749307
##########
hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java:
##########
@@ -38,8 +38,35 @@
import java.util.Arrays;
public class TestMiniKdc extends KerberosSecurityTestcase {
- private static final boolean IBM_JAVA = System.getProperty("java.vendor")
- .contains("IBM");
+ private static final boolean IBM_JAVA = shouldUseIbmPackages();
+ // duplicated to avoid cycles in the build
+ private static boolean shouldUseIbmPackages() {
+ final List<String> ibmTechnologyEditionSecurityModules = Arrays.asList(
+ "com.ibm.security.auth.module.JAASLoginModule",
+ "com.ibm.security.auth.module.Win64LoginModule",
+ "com.ibm.security.auth.module.NTLoginModule",
+ "com.ibm.security.auth.module.AIX64LoginModule",
+ "com.ibm.security.auth.module.LinuxLoginModule",
+ "com.ibm.security.auth.module.Krb5LoginModule"
+ );
+
+ if (System.getProperty("java.vendor").contains("IBM")) {
+ return ibmTechnologyEditionSecurityModules
+ .stream().anyMatch((module) -> isSystemClassAvailable(module));
+ }
+
+ return false;
+ }
+
+ private static boolean isSystemClassAvailable(String className) {
Review Comment:
No strong reasons, other than we shouldn't need the do privileged calls here
in unit tests. I'm happy to make that change for consistency if preferred 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
