li-leyang commented on PR #5160: URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1349892544
I think the original intention was to explicitly invalidate KeyProviderCache at each DFSClient close. We need to explicit close this singleton cache at DFSClient close hence this was added in JVM ShutdownHook. For some cases that KeyProviderCache is not used, I agree that we can swallow the exception and not add shutdownhook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
