[
https://issues.apache.org/jira/browse/HADOOP-8036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209951#comment-13209951
]
Aaron T. Myers commented on HADOOP-8036:
----------------------------------------
{quote}
I've confirmed that aborting the test halfway through (for example, with the
stop button in Eclipse) will NOT invoke the tearDown function.
Given this, it seems prudent to do out cleanup work beforehand. Otherwise
people who manually abort the test halfway through will be hosed. Also, as you
pointed out, there is always the possibility of the JVM aborting, which would
definitely prevent cleanup.
We definitely want to avoid a situation where the Jenkins machine can't build,
but we can, due to some mysterious build artifacts hanging around. So I figure
it makes sense to stay on the safe side.
{quote}
Yea, I buy this, but given that we don't do this anywhere else, I'd rather be
consistent with the rest of the test suite.
In general, I'd be in favor of having any test which mucks with persistent file
system state both a) clean up after itself using an @After (the normal case)
and b) call that same cleanup code in an @Before so that aborted test runs
don't cause subsequent test runs to spuriously fail. Perhaps you could file a
separate JIRA to do that across all the tests?
> TestViewFsTrash assumes the user's home directory is 2 levels deep
> ------------------------------------------------------------------
>
> Key: HADOOP-8036
> URL: https://issues.apache.org/jira/browse/HADOOP-8036
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, test
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8036.txt
>
>
> Looks like HADOOP-7974 didn't fix the issue. Still get "Path /var already
> exists as dir; cannot create link here Stacktrace" when running on jenkins
> with home dir /var/lib/jenkins.
> {noformat}
> org.apache.hadoop.fs.FileAlreadyExistsException: Path /var already exists as
> dir; cannot create link here
> at org.apache.hadoop.fs.viewfs.InodeTree.createLink(InodeTree.java:244)
> at org.apache.hadoop.fs.viewfs.InodeTree.<init>(InodeTree.java:334)
> at
> org.apache.hadoop.fs.viewfs.ViewFileSystem$1.<init>(ViewFileSystem.java:165)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
