pjfanning commented on PR #5224: URL: https://github.com/apache/hadoop/pull/5224#issuecomment-1355461706
> needs a test. > > if bestEffortSet was made package private then tests could go in to > > * verify a known attr is set with result true > * unknown attr is swallowed and returned false. > > we need this as the xml parsers we probably work with will take the attributes production code generates added basic test coverage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
