Daniel-009497 commented on code in PR #5238:
URL: https://github.com/apache/hadoop/pull/5238#discussion_r1051771069
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -717,6 +717,8 @@ public void removeOrTrackCompletedContainersFromContext(
org.apache.hadoop.yarn.server.nodemanager.containermanager.container.ContainerState.DONE))
{
context.getContainers().remove(containerId);
removedContainers.add(containerId);
+ // For the finished containers, the residual data stored in leveldb
should also be cleared
+ addCompletedContainer(containerId);
Review Comment:
Thanks for your review.
Cleaning up here is just be added into a map which will be handled
asynchronously and no exception could be thrown here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
