[
https://issues.apache.org/jira/browse/HADOOP-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210344#comment-13210344
]
Hadoop QA commented on HADOOP-8046:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12514995/HADOOP-8046.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/611//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/611//console
This message is automatically generated.
> Revert ScriptBasedMapping semantics to the existing ones, add DNS mapping
> diagnostics in progress
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8046
> URL: https://issues.apache.org/jira/browse/HADOOP-8046
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-8046.patch, HADOOP-8046.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> HADOOP-7878 still doesn't let the block manager switch to non-scripted
> topologies because the static mapping is still getting it wrong -it should
> just look at the configuration for a non-null script name, as per the usual
> {{ScriptBasedMapping}}, so as to keep tests backwards compatible.
> In the process, make it possible to debug topologies by
> # {{#toString()}} operations to provide summary information, and for the
> {{CachedDNSToSwitchMapping}}, to include information on the inner mapping.
> {{ScriptBasedMapping}} to include the script name.
> # {{AbstractDNSToSwitchMapping} to offer a method {{getSwitchMap()}} to
> return a cloned map of the mapping, or null if this is not known.
> # {{AbstractDNSToSwitchMapping} to offer a method {{dumpTopology()}} to take
> this switch map and the toString() and generate a topology dump suitable for
> humans.
> # Implementing the switch map method for the standard mappings (Cached ->
> cached map, Static -> static map, Script -> null).
> These methods are all for debugging, but there is no reason not to use the
> contents of {{getSwitchMap()}} in service web pages providing details on the
> service's current view of the network topology, as it may differ from the
> expectations of the script author.
> time: 30m to implement, 1h30 to write more tests and run them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
