ashutoshcipher commented on code in PR #5243: URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053287261
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java: ########## @@ -75,13 +73,12 @@ public static void createContainerLogFileInRemoteFS(Configuration conf, if (fs.exists(rootLogDirPath)) { fs.delete(rootLogDirPath, true); } - assertTrue(fs.mkdirs(rootLogDirPath)); + fs.mkdirs(rootLogDirPath); Path appLogsDir = new Path(rootLogDirPath, appId.toString()); if (fs.exists(appLogsDir)) { fs.delete(appLogsDir, true); } - assertTrue(fs.mkdirs(appLogsDir)); - + fs.mkdirs(appLogsDir); Review Comment: Thanks @slfan1989 >hadoop-mapreduce-client-hs and hadoop-mapreduce-client-app may take some time to upgrade junit test. I have already raised PR for both the modules. Can see some failures in `hadoop-mapreduce-client-app` - will fix it as well in that PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org