Daniel-009497 commented on code in PR #5247:
URL: https://github.com/apache/hadoop/pull/5247#discussion_r1053913286


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java:
##########
@@ -506,6 +506,7 @@ public void setEntitlement(String queue, QueueEntitlement 
entitlement)
   private void killOrphanContainerOnNode(RMNode node,
       NMContainerStatus container) {
     if (!container.getContainerState().equals(ContainerState.COMPLETE)) {
+      LOG.warn("Killing container " + container + " for unknown application");

Review Comment:
   > Will this change result in more log output? Does this mean that all apps 
that enter this judgment must be printed?
   
   @slfan1989  Not really, Only the orphan container which status is unfinished 
will be killed and logged here.  What is really matters is the minority ones be 
handled not the majority ones be skipped. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to