brumi1024 commented on code in PR #5201:
URL: https://github.com/apache/hadoop/pull/5201#discussion_r1056205229
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java:
##########
@@ -310,6 +313,7 @@ private void convertCapacitySchedulerXml(FairScheduler fs) {
.withPercentages(usePercentages)
.build();
+ queueConverter.emitDefaultUserLimitFactor(fsLeafQueue,
capacitySchedulerConfig);
Review Comment:
This should ideally be called from inside the queueConverter, as this method
operates on queues themselves, not on the whole structure. This way there is no
need to get the leafQueues array.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java:
##########
@@ -215,6 +219,19 @@ private void emitPreemptionDisabled(String queueName,
FSQueue queue) {
}
}
+ public void emitDefaultUserLimitFactor(Collection<FSLeafQueue> fsLeafQueue,
CapacitySchedulerConfiguration config) {
+ fsLeafQueue
Review Comment:
There is no need to iterate through the queues, as the convertQueueHierarchy
does that. Calling this method there and checking if the queue that we're
currently converting is a leafQueue should achieve what we're trying to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
