slfan1989 commented on code in PR #4543:
URL: https://github.com/apache/hadoop/pull/4543#discussion_r1057240710
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##########
@@ -1366,4 +1393,44 @@ public void shutdown() {
threadpool.shutdown();
}
}
+
+ private <R> Map<SubClusterInfo, R>
invokeConcurrent(Collection<SubClusterInfo> clusterIds,
+ ClientMethod request, Class<R> clazz) {
+
+ Map<SubClusterInfo, R> results = new HashMap<>();
+
+ // Send the requests in parallel
+ CompletionService<R> compSvc = new
ExecutorCompletionService<>(this.threadpool);
+
+ for (final SubClusterInfo info : clusterIds) {
+ compSvc.submit(() -> {
+ DefaultRequestInterceptorREST interceptor =
getOrCreateInterceptorForSubCluster(
+ info.getSubClusterId(), info.getRMWebServiceAddress());
+ try {
+ Method method = DefaultRequestInterceptorREST.class.
+ getMethod(request.getMethodName(), request.getTypes());
+ Object retObj = method.invoke(interceptor, request.getParams());
+ R ret = clazz.cast(retObj);
+ return ret;
+ } catch (Exception e) {
+ LOG.error("SubCluster {} failed to call {} method.",
info.getSubClusterId(),
+ request.getMethodName(), e);
+ return null;
+ }
+ });
+ }
+
+ clusterIds.stream().forEach(clusterId -> {
+ try {
+ Future<R> future = compSvc.take();
+ R response = future.get();
+ if (response != null) {
+ results.put(clusterId, response);
Review Comment:
Thank you very much for your feedback, I agree with your description. For
the results of the FederationInterceptorREST interface, we will integrate the
results returned by all subClusters. This part does not care about the return
order of multi-threads. I've submitted a Follow Up pr to fix this, thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
