mkuchenbecker commented on code in PR #5257:
URL: https://github.com/apache/hadoop/pull/5257#discussion_r1060273952
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##########
@@ -203,6 +203,9 @@ public class RouterRpcServer extends AbstractService
implements ClientProtocol,
/** Router using this RPC server. */
private final Router router;
+ /** RouterStateIdContext for this RPC server. */
Review Comment:
Nit. Prefer comments that explain rather than describe the code.
```
/** Interface to map global name space to HDFS subcluster name spaces. */
private final FileSubclusterResolver subclusterResolver;
```
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##########
@@ -510,6 +513,15 @@ BalanceProcedureScheduler getFedRenameScheduler() {
return this.fedRenameScheduler;
}
+ /**
+ * Get the routerStateIdContext used by this server.
+ * @return routerStateIdContext
+ */
+ @VisibleForTesting
+ public RouterStateIdContext getRouterStateIdContext() {
Review Comment:
Does protected not work? i.e. Your test should be able to access a protected
member.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
