pranavsaxena-microsoft commented on code in PR #3440:
URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062132104
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -1666,7 +1715,8 @@ private boolean parseIsDirectory(final String
resourceType) {
&& resourceType.equalsIgnoreCase(AbfsHttpConstants.DIRECTORY);
}
- private String convertXmsPropertiesToCommaSeparatedString(final
Hashtable<String, String> properties) throws
+ public String convertXmsPropertiesToCommaSeparatedString(final
Hashtable<String,
Review Comment:
1. Have made it package-protected.
2. Added javadocs.
3. added `@VisibleForTesting` annotation.
4. Changed to Map rather than HashTable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
