ahmarsuhail commented on code in PR #4499: URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062386144
########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ########## @@ -353,10 +352,10 @@ it is authenticated with; the role token binding will fail. When the AWS credentials supplied to the Session Delegation Token binding through `fs.s3a.aws.credentials.provider` are themselves a set of Review Comment: this seems fine to me as is. Maybe removing the themselves entirely would help, so it becomes "through `fs.s3a.aws.credentials.provider` are a set of", but personally feel it's clearer as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
