tomscut commented on code in PR #5276: URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063015972
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ########## @@ -97,6 +99,8 @@ private final TreeMap<String, MountTable> tree = new TreeMap<>(); /** Path -> Remote location. */ private final Cache<String, PathLocation> locationCache; + public static LongAdder locCacheMissed = new LongAdder(); + public static LongAdder locCacheAccessed = new LongAdder(); Review Comment: Those metrics make sense to me. One little advice: update `locCacheMissed` to `locCacheMiss`, and update `locCacheAccessed` to `locCacheHit`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
