goiri commented on code in PR #5272:
URL: https://github.com/apache/hadoop/pull/5272#discussion_r1064112228
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##########
@@ -1145,10 +1147,59 @@ public SchedulerTypeInfo getSchedulerInfo() {
throw new NotImplementedException("Code is not implemented");
}
+ /**
+ * This method dumps the scheduler logs for the time got in input, and it is
+ * reachable by using {@link RMWSConsts#SCHEDULER_LOGS}.
+ *
+ * @param time the period of time. It is a FormParam.
+ * @param hsr the servlet request
+ * @return the result of the operation
+ * @throws IOException when it cannot create dump log file
+ */
@Override
public String dumpSchedulerLogs(String time, HttpServletRequest hsr)
throws IOException {
- throw new NotImplementedException("Code is not implemented");
+
+ if (StringUtils.isBlank(time)) {
+ routerMetrics.incrDumpSchedulerLogsFailedRetrieved();
+ throw new IllegalArgumentException("Parameter error, the time is empty
or null.");
+ }
+
+ int period = Integer.parseInt(time);
Review Comment:
Can this get a string that is not a number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
