brumi1024 commented on code in PR #5278:
URL: https://github.com/apache/hadoop/pull/5278#discussion_r1065729095
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java:
##########
@@ -309,6 +314,18 @@ private void checkMaxChildCapacitySetting(FSQueue queue) {
}
}
+ private boolean checkAutoQueueCreationV2Disabled(String queueName) {
+ return !capacitySchedulerConfig.getBoolean(
+ PREFIX + queueName + DOT + AUTO_QUEUE_CREATION_V2_ENABLED,
+ DEFAULT_AUTO_QUEUE_CREATION_ENABLED);
+ }
+
+ private boolean checkAutoCreateChildQueueDisabled(String queueName) {
+ return !capacitySchedulerConfig.getBoolean(
+ PREFIX + queueName + DOT + AUTO_CREATE_CHILD_QUEUE_ENABLED,
+ DEFAULT_AUTO_CREATE_CHILD_QUEUE_ENABLED);
+ }
Review Comment:
These methods already exist in CapacitySchedulerConfiguration, mentioned the
method names in my previous comments. Please use those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
