huangxiaopingRD commented on PR #5287: URL: https://github.com/apache/hadoop/pull/5287#issuecomment-1378178062
> @huangxiaopingRD , thank you for the patch. I requested one small change. > > CI reported a JavaDoc error, but it's not related to this patch. We have an existing JavaDoc problem tracked elsewhere. > > I think the jdiff XML files should be left alone, because they are part of an already published release. These files get generated at the time of a new release ([HowToRelease](https://cwiki.apache.org/confluence/display/HADOOP2/HowToRelease)), and we don't generally modify them afterwards. CC @mukund-thakur for a second opinion as someone who has done more release work lately. @cnauroth It has been modified in another PR(https://github.com/apache/hadoop/pull/5291), thank you for helping to review this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
