brumi1024 commented on PR #5289: URL: https://github.com/apache/hadoop/pull/5289#issuecomment-1378482132
Thanks @slfan1989 for the quick reaction! I think the test is at fault here, because the properties that doesn't match this [pattern](https://github.com/apache/hadoop/blob/570b503e3e7e7adf5b0a8fabca76003298216543/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java#L197) are filtered out. So basically every configuration property that has the %s in its name for string replacement will break this test if it gets documented, which is exactly the opposite of what this test should be doing. Can you please update the pattern instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
