PrabhuJoseph commented on PR #5293:
URL: https://github.com/apache/hadoop/pull/5293#issuecomment-1381382711

   @cnauroth  Thanks for the review.
   
   1. All those Jiras pointed out above are related to QueueMetrics which is 
still going to be the same. This patch addresses the issues with 
ClusterMetricsInfo shown in RMWebService.
   2. Currently, ClusterMetricsInfo shows available or allocated memory only 
for Default Partition. I don't think this is by intention, if so there has to 
be at least one test case failed with this patch. From the name 
ClusterMetricsInfo, it is Cluster Wide, showing only for Default Partition does 
not look right and also does not help clusters where some/all nodes are part of 
non-default partitions.
   3. Without this patch, currently i see there is no way to retrieve the 
Cluster Wide Available and Allocated Memory. But we have ways to get it for 
Partition level already through QueueMetrics . Having both ClusterMetrics and 
QueueMetrics showing for Default Partition seems redundant. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to