goiri commented on code in PR #5260:
URL: https://github.com/apache/hadoop/pull/5260#discussion_r1072504854
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##########
@@ -45,7 +45,7 @@
import org.apache.commons.lang3.NotImplementedException;
import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.lang3.tuple.Pair;
+import org.apache.commons.lang3.tuple.Triple;
Review Comment:
FederationInterceptorREST.java:48:import
org.apache.commons.lang3.tuple.Triple;:8: Unused import -
org.apache.commons.lang3.tuple.Triple. [UnusedImports]
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##########
@@ -2496,7 +2497,8 @@ private <R> Map<SubClusterInfo, R>
invokeConcurrent(Collection<SubClusterInfo> c
// If there is a sub-cluster access error,
// we should choose whether to throw exception information according to
user configuration.
// Send the requests in parallel.
- CompletionService<Pair<R, Exception>> compSvc = new
ExecutorCompletionService<>(threadpool);
+ CompletionService<SubClusterResult<R>> compSvc =
Review Comment:
One line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
