virajjasani commented on code in PR #5294:
URL: https://github.com/apache/hadoop/pull/5294#discussion_r1072755319
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -733,7 +733,11 @@ public Object run() throws IOException,
InterruptedException {
+ UserGroupInformation.getLoginUser().getUserName() + " to "
+ remoteId;
LOG.warn(msg, ex);
- throw new IOException(msg, ex);
+ throw NetUtils.wrapException(remoteId.getAddress().getHostName(),
+ remoteId.getAddress().getPort(),
+ NetUtils.getHostname(),
+ 0,
+ new IOException(msg, ex));
Review Comment:
> preserve the type of the exception as it goes down. this keeps the
information and removes one level of exception wrapping
Agree, updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
