szilard-nemeth commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1086928113
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java: ########## @@ -456,6 +456,19 @@ public int getActiveRMIndex() { return -1; } + /** + * Stop a MiniYarnCluster can take more than 30s what blocks the test execution, + * so to prevent that we can start the cluster stop asynchronously, + * what can decrease the test execution time. + * @param owner the Test class, what owns the instance of MiniYarnCluster + */ + public void asyncStop(Object owner) { Review Comment: ```suggestion * Stopping MiniYarnCluster can take more than 30 seconds and it's a blocking operation so it blocks test execution, * so to prevent that we can stop the cluster asynchronously, * that can ultimately save test execution time. * @param owner the Test class that owns the instance of MiniYarnCluster */ public void asyncStop(Object owner) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org