[
https://issues.apache.org/jira/browse/HADOOP-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681595#comment-17681595
]
ASF GitHub Bot commented on HADOOP-18584:
-----------------------------------------
jojochuang commented on code in PR #5252:
URL: https://github.com/apache/hadoop/pull/5252#discussion_r1089771999
##########
hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/RpcUtil.java:
##########
@@ -170,15 +172,18 @@ public void channelRead(ChannelHandlerContext ctx, Object
msg)
*/
@ChannelHandler.Sharable
private static final class RpcUdpResponseStage extends
- ChannelInboundHandlerAdapter {
+ SimpleChannelInboundHandler<RpcResponse> {
+ public RpcUdpResponseStage() {
+ // do not auto release the RpcResponse message.
Review Comment:
no... i checked with io.netty.leakDetection.level=PARANOID, and it would
actually throw an exception because the refcount would go negative.
The response is released. Looks like IdleStateHandler releases the object
for us.
> [NFS GW] Fix regression after netty4 migration
> ----------------------------------------------
>
> Key: HADOOP-18584
> URL: https://issues.apache.org/jira/browse/HADOOP-18584
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Major
> Labels: pull-request-available
>
> Two bugs were found recently. Both related to hadoop portmap utility.
> (1) The ChannelHandler that can be added to a ChannelPipeline in Netty4 must
> be Shareable. However, IdleStateHandler, used by Portmap is not. We need to
> fix it otherwise hadoop portmap may fail to start.
> (2) RpcUdpResponseStage does not get the request from client (hadoop mountd)
> because of response type mismatch, and therefore it does not respond back to
> client request.
> This is a regression from HADOOP-11245 but I consider it not a blocker,
> because most recent Linux distro supports rpcbind and there's little reason
> to use Hadoop's portmap.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
