hfutatzhanghb opened a new pull request, #5330:
URL: https://github.com/apache/hadoop/pull/5330

   Now in method processCommandFromActor,  we have code like below:
   
   ```java
   writeLock();
   try {
     if (actor == bpServiceToActive) {
       return processCommandFromActive(cmd, actor);
     } else {
       return processCommandFromStandby(cmd, actor);
     }
   } finally {
     writeUnlock();
   } 
   ```
   
   if method processCommandFromActive costs much time, the write lock would not 
release.
   
   
   It maybe block the `updateActorStatesFromHeartbeat` method in 
offerService,furthermore, it can cause the lastcontact of datanode very high, 
even dead when lastcontact beyond 600s.
   
   ```java
   bpos.updateActorStatesFromHeartbeat(
       this, resp.getNameNodeHaState());
   ```
   
   here we can make write lock fine-grain in processCommandFromActor method to 
address this problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to