[
https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682187#comment-17682187
]
ASF GitHub Bot commented on HADOOP-18206:
-----------------------------------------
virajjasani commented on PR #5315:
URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1408995424
> I've reviewed where log4j gets used in the production code. I do worry
that today there's enough reflection that if deployed with logback all is good,
but now log4j is required.
Even without this patch, if we don't have log4j in classpath, hdfs cannot
come up right? For instance, `MetricsLoggerTask` is adding appenders
dynamically and for that, we do need appender classes to be present in the
classpath, meaning log4j is mandatory in the classpath.
However, I am going to cover all dynamic async appenders and replace with
log4j properties, then we can directly use SLF4J and remove all Log4J
references in the codebase. Does this sound good?
> Cleanup the commons-logging references in the code base
> -------------------------------------------------------
>
> Key: HADOOP-18206
> URL: https://issues.apache.org/jira/browse/HADOOP-18206
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> Should always use slf4j
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
