goiri commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1091027952
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ########## @@ -4299,6 +4299,26 @@ public static boolean isAclEnabled(Configuration conf) { ROUTER_PREFIX + "interceptor.allow-partial-result.enable"; public static final boolean DEFAULT_ROUTER_INTERCEPTOR_ALLOW_PARTIAL_RESULT_ENABLED = false; + /** Router SubCluster Cleaner Thread Clean Interval Time. **/ + public static final String ROUTER_SUBCLUSTER_CLEANER_INTERVAL_TIME = + ROUTER_PREFIX + "subcluster.cleaner.interval.time"; + public static final long DEFAULT_ROUTER_SUBCLUSTER_CLEANER_INTERVAL_TIME = 60000; Review Comment: If we are using getTimeDuration, let's use something easier to read here like TimeUnit.Seconds.ToMillis(60) or "60s" might also work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org