virajjasani commented on code in PR #5315:
URL: https://github.com/apache/hadoop/pull/5315#discussion_r1092394399
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/ServiceOperations.java:
##########
@@ -67,26 +66,6 @@ public static Exception stopQuietly(Service service) {
return stopQuietly(LOG, service);
}
- /**
- * Stop a service; if it is null do nothing. Exceptions are caught and
- * logged at warn level. (but not Throwables). This operation is intended to
- * be used in cleanup operations
- *
- * @param log the log to warn at
- * @param service a service; may be null
- * @return any exception that was caught; null if none was.
- * @see ServiceOperations#stopQuietly(Service)
- */
- public static Exception stopQuietly(Log log, Service service) {
Review Comment:
The problem is, if we deprecate this now, we will have to keep this method.
If we keep this method, then we can't cleanup commons-logging from our
codebase, because the first arg of the method is still referring to
commons-logging logger i.e. `org.apache.commons.logging.Log`.
Hence if we don't remove this method with this patch, the purpose of this
patch is not fully achieved?
On the other hand, on 3.3 we can't completely remove commons-logging (i.e.
this patch can't be applied to branch-3.3) because of this exact compatibility
reason.
> i don't think it's used outside our own codebase, fwiw
i also think the same. would be surprised if any downstreamer uses this
method with direct exposure to commons-logging logger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
