steveloughran commented on code in PR #5301:
URL: https://github.com/apache/hadoop/pull/5301#discussion_r1097763234
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -896,15 +896,26 @@ public Builder setNumHandlers(int numHandlers) {
this.numHandlers = numHandlers;
return this;
}
-
- /**
+
+ /**@deprecated call {@link #setNumReaders(int value)} instead.
Review Comment:
can you put that on the line below.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -896,15 +896,26 @@ public Builder setNumHandlers(int numHandlers) {
this.numHandlers = numHandlers;
return this;
}
-
- /**
+
+ /**@deprecated call {@link #setNumReaders(int value)} instead.
+ *
* @return Default: -1.
* @param numReaders input numReaders.
*/
- public Builder setNumReaders(int numReaders) {
+ @Deprecated
+ public Builder setnumReaders(int numReaders) {
this.numReaders = numReaders;
return this;
}
+
+ /**
+ * @return Default: -1.
Review Comment:
1. add "set the number of reader threads"
2. return value is "this builder"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
