virajjasani commented on PR #5343: URL: https://github.com/apache/hadoop/pull/5343#issuecomment-1419653059
I was just able to confirm that if we revert https://github.com/apache/hadoop/commit/90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb commit and refresh IDE maven cache, we would run into issues, otherwise this commit has taken care of providing `hadoop.log.dir` value as `${project.build.directory}/log` that applies to all modules including hadoop-hdfs. What I did realize is that we have some redundancy with setting `hadoop.log.dir` on multiple sub-modules, which should be removed because the value of `hadoop.log.dir` would anyways be set up by hadoop-project pom which is parent of all modules poms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
