Hexiaoqiao commented on code in PR #5359:
URL: https://github.com/apache/hadoop/pull/5359#discussion_r1099749574
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java:
##########
@@ -84,9 +84,9 @@ public EditLogFileOutputStream(Configuration conf, File name,
int size)
doubleBuf = new EditsDoubleBuffer(size);
RandomAccessFile rp;
if (shouldSyncWritesAndSkipFsync) {
Review Comment:
Yes, absolutely right! It's very interesting journey while try to review
this code segment again, I have checked in one unreasonable improvement
(HDFS-15882) because I mislead this parameter meaning.
Now this changes is pretty good and is expected.
LGTM. +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
