snmvaughan commented on PR #4835: URL: https://github.com/apache/hadoop/pull/4835#issuecomment-1425072948
From what I've seen, many of the timeouts are related to: - Resources that aren't shutdown appropriately, leaving background threads that aren't daemon threads - Interactions between tests when run concurrently, where the tests operate using the same space This fix is focussed on both issues, as it uses a `TemporaryFolder` to avoid sharing space between tests and ensures that the cluster and its resources are always shutdown. I'd hope that we would expand this to the remaining uses of the mini clusters. Originally I had proposed new calls that actually took a `TemporaryFolder` as a parameter, thinking we'd eventually phase out the `File`-based calls and drop them entirely to ensure consistency. In addition, I've been submitting PRs that address some of the threading issues (e.g. [HDFS-16904](https://issues.apache.org/jira/browse/HDFS-16904) and [HADOOP-18279](https://issues.apache.org/jira/browse/HADOOP-18279). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
