steveloughran commented on code in PR #5385:
URL: https://github.com/apache/hadoop/pull/5385#discussion_r1104483880
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2033,8 +2034,12 @@ public Connection(SocketChannel channel, long
lastContact,
this.isOnAuxiliaryPort = isOnAuxiliaryPort;
if (addr == null) {
this.hostAddress = "*Unknown*";
+ this.hostName = this.hostAddress;
Review Comment:
use NetUtils.getHostNameOfIP() and similar for all this. gives us one point
of maintenance, testing, upgrading to ipv6 etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
