[
https://issues.apache.org/jira/browse/HADOOP-18215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688851#comment-17688851
]
ASF GitHub Bot commented on HADOOP-18215:
-----------------------------------------
ayushtkn commented on PR #4215:
URL: https://github.com/apache/hadoop/pull/4215#issuecomment-1430812485
To me it sounds ok, regarding the one liner, if that is a strickt ask and if
other people are convinced I am ok with that as well. But it isn't something
where I am the only one approving it. I will play it safe, Utility classes does
get used a lot, Even FileUtils, Utils are all annotated Evolving, but if you
break it, you will break a lot of stuff. Something which is there more than 10
years....
The codes being impacted are around 2008-09, I am not sure who has direct
involvement during development, like why it was done like that or so.
@steveloughran / @goiri / @vinayakumarb anyone any context or feedback
around this?
> Enhance WritableName to be able to return aliases for classes that use
> serializers
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-18215
> URL: https://issues.apache.org/jira/browse/HADOOP-18215
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Assignee: Bryan Beaudreault
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> WritableName allows users shim in aliases for writables, in the case where a
> SequenceFile was written with a Writable class that has since been renamed or
> moved to another package. However, this requires that the aliased class
> extend Writable.
> Separately it's possible to configure jobs with keys and values which don't
> actually extend Writable. Instead they are meant to be
> serialized/deserialized using the serialization classes defined in
> {{io.serializations}} config.
> Unfortunately, the current implementation does not support these key/value
> classes. All we need to do to support this is remove the
> {{.asSubclass(Writable.class)}} as is already the case for the default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
