[
https://issues.apache.org/jira/browse/HADOOP-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689048#comment-17689048
]
ASF GitHub Bot commented on HADOOP-18633:
-----------------------------------------
mehakmeet opened a new pull request, #5401:
URL: https://github.com/apache/hadoop/pull/5401
### Description of PR
Fixing test flakiness caused by race condition.
### How was this patch tested?
Tested (ap-south-1)S3a,(us-west-2) ABFS, HDFS and LocalFS implementation of
the test.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> fix test AbstractContractDistCpTest#testDistCpUpdateCheckFileSkip
> ------------------------------------------------------------------
>
> Key: HADOOP-18633
> URL: https://issues.apache.org/jira/browse/HADOOP-18633
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools/distcp
> Reporter: Mehakmeet Singh
> Assignee: Mehakmeet Singh
> Priority: Major
>
> In the newly introduced test testDistCpUpdateCheckFileSkip, for the first
> pass of "distcp -update", target file should not be present so that the copy
> takes place and creates the target file.
> Currently, we create both the source and target file with same block size
> from the start which can lead to flakiness due to race condition causing the
> modification time of the target file to be greater than/equal to the source
> and not copy the file at all. This can be seen more in the
> TestLocalContractDistCp due to no remote calls to create the target.
> {code:java}
> java.lang.AssertionError: Mismatch in COPY counter value expected:<1> but
> was:<0>
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
> at org.junit.Assert.assertEquals(Assert.java:647)
> at
> org.apache.hadoop.tools.contract.AbstractContractDistCpTest.verifySkipAndCopyCounter(AbstractContractDistCpTest.java:1000)
> at
> org.apache.hadoop.tools.contract.AbstractContractDistCpTest.testDistCpUpdateCheckFileSkip(AbstractContractDistCpTest.java:919)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
