virajjasani commented on PR #5396: URL: https://github.com/apache/hadoop/pull/5396#issuecomment-1433713252
> The Dn case seems a corner case, it won't be very common and need to be careful around not getting pass a split-brain scenario. There are bunch of checks around though, but they are just to verify we don't get a false active claim acknowledged.. Oh yes, this was my first focus, I tried adding bunch of logs internally just to ensure if we are seeing some bugs here, but so far things look good. It's the TCP connection that Envoy infra is messing up (only sometimes, not often). But nvm, this is still worth spending time on. Thanks for all good points, I am going to close this PR mostly soon (just figuring out a few more details) so that it doesn't pile up in the open PRs. Thanks a lot for spending a lot of your time here, it's just so priceless! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
