slfan1989 commented on code in PR #5394:
URL: https://github.com/apache/hadoop/pull/5394#discussion_r1109812955
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/FederationStateStore.java:
##########
@@ -60,7 +60,21 @@ public interface FederationStateStore extends
* Load the version information from the federation state store.
*
* @return the {@link Version} of the federation state store
+ * @throws Exception an exception occurred in load version.
*/
- Version loadVersion();
+ Version loadVersion() throws Exception;
Review Comment:
Thank you for helping to review the code, I will add tests, but this pr is a
framework, I will add some simple tests. It will be implemented in
`MemoryFederationStateStore`, `SQLFederationStateStore`, and
`ZookeeperFederationStateStore` later. When these functions are completed, I
will add more test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
