xinglin commented on code in PR #5367:
URL: https://github.com/apache/hadoop/pull/5367#discussion_r1116566616
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -1485,6 +1487,10 @@ Writable call(RPC.RpcKind rpcKind, Writable rpcRequest,
releaseAsyncCall();
}
throw e;
+ } finally {
+ if (!success) {
+ connection.calls.remove(call.id);
Review Comment:
sendRpcRequest(call) will try to add a pair of <call,buf> into
rpcRequestQueue. Should we remove that on failure as well?
` rpcRequestQueue.put(Pair.of(call, buf));
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
