steveloughran commented on PR #5429:
URL: https://github.com/apache/hadoop/pull/5429#issuecomment-1443610860
HDFS failures, all of which I consider to be race conditions/timing issues
and so not blockers.
## TestDataNodeRollingUpgrade.deleteAndEnsureInTrash
```
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
at
org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade.deleteAndEnsureInTrash(TestDataNodeRollingUpgrade.java:141)
at
org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade.testWithLayoutChangeAndRollback(TestDataNodeRollingUpgrade.java:420)
```
is an assert after some heartbeats
```
triggerHeartBeats();
assertTrue(trashFile.exists()); // here
assertFalse(blockFile.exists());
```
The file was deleted, just didn't show up
## TestBalancerWithHANameNodes.testBalancerWithObserverWithFailedNode:
timeout
```
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes.testBalancerWithObserverWithFailedNode
Failing for the past 1 build (Since #4 )
Took 3 min 0 sec.
Error Message
test timed out after 180000 milliseconds
Stacktrace
org.junit.runners.model.TestTimedOutException: test timed out after 180000
milliseconds
```
## TestDFSAdmin.testAllDatanodesReconfig
race condition; created https://issues.apache.org/jira/browse/HDFS-16934
## TestFsDatasetImpl.testReportBadBlocks
```
Failing for the past 1 build (Since #4 )
Took 7.4 sec.
Error Message
expected:<1> but was:<0>
Stacktrace
java.lang.AssertionError: expected:<1> but was:<0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
```
assert is after a 3s sleep waiting for reports coming in. Going to brittle
against delays. creating a jira; LambdaTestUtils.eventually() should be used
around this assert
```
dataNode.reportBadBlocks(block, dataNode.getFSDataset()
.getFsVolumeReferences().get(0));
Thread.sleep(3000); // 3s
sleep
BlockManagerTestUtil.updateState(cluster.getNamesystem()
.getBlockManager());
// Verify the bad block has been reported to namenode
Assert.assertEquals(1,
cluster.getNamesystem().getCorruptReplicaBlocks()); // here
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
