[
https://issues.apache.org/jira/browse/HADOOP-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696169#comment-17696169
]
ASF GitHub Bot commented on HADOOP-18649:
-----------------------------------------
Apache9 commented on code in PR #5448:
URL: https://github.com/apache/hadoop/pull/5448#discussion_r1124529132
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/resources/container-log4j.properties:
##########
@@ -26,36 +26,31 @@ log4j.threshold=ALL
#
#Default values
-yarn.app.container.log.dir=null
-yarn.app.container.log.filesize=100
+yarn.app.container.log.filesize=100MB
-log4j.appender.CLA=org.apache.hadoop.yarn.ContainerLogAppender
-log4j.appender.CLA.containerLogDir=${yarn.app.container.log.dir}
-log4j.appender.CLA.containerLogFile=${hadoop.root.logfile}
-log4j.appender.CLA.totalLogFileSize=${yarn.app.container.log.filesize}
+log4j.appender.CLA=org.apache.log4j.RollingFileAppender
+log4j.appender.CLA.File=${yarn.app.container.log.dir}/${hadoop.root.logfile}
+log4j.appender.CLA.MaxFileSize=${yarn.app.container.log.filesize}
Review Comment:
We should also config MaxBackupIndex? What is the default value if we do not
set it?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/resources/container-log4j.properties:
##########
@@ -26,36 +26,31 @@ log4j.threshold=ALL
#
#Default values
-yarn.app.container.log.dir=null
-yarn.app.container.log.filesize=100
+yarn.app.container.log.filesize=100MB
-log4j.appender.CLA=org.apache.hadoop.yarn.ContainerLogAppender
-log4j.appender.CLA.containerLogDir=${yarn.app.container.log.dir}
-log4j.appender.CLA.containerLogFile=${hadoop.root.logfile}
-log4j.appender.CLA.totalLogFileSize=${yarn.app.container.log.filesize}
+log4j.appender.CLA=org.apache.log4j.RollingFileAppender
+log4j.appender.CLA.File=${yarn.app.container.log.dir}/${hadoop.root.logfile}
+log4j.appender.CLA.MaxFileSize=${yarn.app.container.log.filesize}
log4j.appender.CLA.layout=org.apache.log4j.PatternLayout
log4j.appender.CLA.layout.ConversionPattern=%d{ISO8601} %p [%t] %c: %m%n
-log4j.appender.CRLA=org.apache.hadoop.yarn.ContainerRollingLogAppender
-log4j.appender.CRLA.containerLogDir=${yarn.app.container.log.dir}
-log4j.appender.CRLA.containerLogFile=${hadoop.root.logfile}
-log4j.appender.CRLA.maximumFileSize=${yarn.app.container.log.filesize}
-log4j.appender.CRLA.maxBackupIndex=${yarn.app.container.log.backups}
+log4j.appender.CRLA=org.apache.log4j.RollingFileAppender
+log4j.appender.CRLA.File=${yarn.app.container.log.dir}/${hadoop.root.logfile}
+log4j.appender.CRLA.MaxFileSize=${yarn.app.container.log.filesize}
+log4j.appender.CRLA.MaxBackupIndex=${yarn.app.container.log.backups}
log4j.appender.CRLA.layout=org.apache.log4j.PatternLayout
log4j.appender.CRLA.layout.ConversionPattern=%d{ISO8601} %p [%t] %c: %m%n
-log4j.appender.shuffleCLA=org.apache.hadoop.yarn.ContainerLogAppender
-log4j.appender.shuffleCLA.containerLogDir=${yarn.app.container.log.dir}
-log4j.appender.shuffleCLA.containerLogFile=${yarn.app.mapreduce.shuffle.logfile}
-log4j.appender.shuffleCLA.totalLogFileSize=${yarn.app.mapreduce.shuffle.log.filesize}
+log4j.appender.shuffleCLA=org.apache.log4j.RollingFileAppender
+log4j.appender.shuffleCLA.File=${yarn.app.container.log.dir}/${yarn.app.mapreduce.shuffle.logfile}
+log4j.appender.shuffleCLA.MaxFileSize=${yarn.app.mapreduce.shuffle.log.filesize}
Review Comment:
Ditto.
> CLA and CRLA appenders to be replaced with RFA
> ----------------------------------------------
>
> Key: HADOOP-18649
> URL: https://issues.apache.org/jira/browse/HADOOP-18649
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> ContainerLogAppender and ContainerRollingLogAppender both have quite similar
> functionality as RollingFileAppender. Maintenance of custom appenders for
> Log4J2 is costly when there is very minor difference in comparison with
> built-in appender provided by Log4J.
> The goal of this sub-task is to replace both ContainerLogAppender and
> ContainerRollingLogAppender custom appenders with RollingFileAppender without
> changing any system properties already being used to determine file name,
> file size, backup index, pattern layout properties etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
