ayushtkn commented on PR #5451: URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454095017
> Do not delete file in TestFsck because it's already used by other tests (this should anyways be followed even though we go with other solutions) & > Moving the test to other module so it can use different log4j properties (not preferred) I am against this. First one is being too much confident, that tests won't collide and today we know they aren't. tommorow if suddenly they do, other folks who doesn't know about it would be struggling to figure this out. We don't want to leave the code in a worse state than we have today. Second one I already have said the reason above > Have a new custom log4j properties and hack loading it dynamically for TestFsck (some yarn test does this hack as of today) If they are doing only, then we have a solution ready only, lets do it or pull that into a util and use it everywhere. I don't have hard feeling about other options(as of now), but this one sounds best to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
