[
https://issues.apache.org/jira/browse/HADOOP-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696662#comment-17696662
]
ASF GitHub Bot commented on HADOOP-18629:
-----------------------------------------
zhuyaogai commented on code in PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#discussion_r1125837868
##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/OptionsParser.java:
##########
@@ -239,6 +239,21 @@ public static DistCpOptions parse(String[] args)
}
}
+ if (command.hasOption(DistCpOptionSwitch.FAVORED_NODES.getSwitch())) {
+ String favoredNodesStr = getVal(command,
DistCpOptionSwitch.FAVORED_NODES.getSwitch().trim());
+ if (StringUtils.isEmpty(favoredNodesStr)) {
Review Comment:
Add new UT in `TestOptionsParser`, and I think it's ok that YARN cluster can
resolve favored nodes. BTW, it seems that DN does not care about `port` but
`hostname`?
https://github.com/apache/hadoop/blob/2a0dc2ab2f5fb46dc540ed440d6c8b2896dd195b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java#L703
> Hadoop DistCp supports specifying favoredNodes for data copying
> ---------------------------------------------------------------
>
> Key: HADOOP-18629
> URL: https://issues.apache.org/jira/browse/HADOOP-18629
> Project: Hadoop Common
> Issue Type: New Feature
> Components: tools/distcp
> Affects Versions: 3.3.4
> Reporter: zhuyaogai
> Priority: Major
> Labels: pull-request-available
>
> When importing large scale data to HBase, we always generate the hfiles with
> other Hadoop cluster, use the Distcp tool to copy the data to the HBase
> cluster, and bulkload data to HBase table. However, the data locality is
> rather low which may result in high query latency. After taking a compaction
> it will recover. Therefore, we can increase the data locality by specifying
> the favoredNodes in Distcp.
> Could I submit a pull request to optimize it?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
